Re: xcb-utilities is not built with jhalfs

On Thursday, November 28th, 2024 at 23:38, Douglas R. Reno <[email protected]> wrote:
> 
> Hi Zhang,
> 
> With Pierre AFK I'm supposed to be taking care of jhalfs.
> Can you please compile a list of things that are broken so that I can take a
> look at them when I have time?
> 
> I'd like to have the support working in time for the JDK releases in January.
> That requires me to build two systems in VMs every time due to underlying
> dependency changes, so having it semi- automated would be quite helpful.
> 
> Thank you,
> 
> - Doug
>
>> Hi Doug,
>> The JDK use JOBS=N instead of -jN as make flag for parallel build. This
>> is the only thing i realized when building OpenJDK with jhalfs.

I think I have a patch for JHALFS that will take care of, or at 
least point the way to taking care of, the issue, raised by Zhang
Wen, vis:

I have chosen to check, in BLFS/xsl/scripts.xsl, 
for the package section id tage being 'openjdk', 
and add an 

unset MAKEFLAGS 

line into the build script that gets created, instead of the 

export MAKEFLAGS="-j$(nprocs)" 

that is the current default for every package.


Note the patch merely ditches the default MAKEFLAGS, on the assumption
that someone wanting to do a parallal build would be editing the script
so as to add the optional "-with-jobs=<X>" configure switch into the
configure stanza anyway.

I suppose that one could replace the "unset MAKEFLAGS" in my effort with 

MAKEFLAGS="JOBS=$(nproc)"

but that would seem to override the use of configure to create a "correct"
Makefile.

I did generate the JHALFS build script for openjdk using a patched
version, and it does do what I decribe above.

I'll attach the patch, but also in-line it so you can have a read
here, modulo any mail-client-space-ferkeling.



diff --git a/BLFS/xsl/scripts.xsl b/BLFS/xsl/scripts.xsl
index 6c2997c..5d03658 100644
--- a/BLFS/xsl/scripts.xsl
+++ b/BLFS/xsl/scripts.xsl
@@ -193,16 +193,24 @@ export JH_KEEP_FILES="</xsl:text>
      parallel jobs. This supposes that ninja has been build with
      support for NINJAJOBS in lfs. We'll have to change that code
      if lfs changes its policy for ninja. -->
-      <xsl:text>export MAKEFLAGS="-j</xsl:text>
       <xsl:choose>
-        <xsl:when test="$jobs = 0">
-          <xsl:text>$(nproc)"
+        <xsl:when test="@id='openjdk'">
+          <xsl:text>unset MAKEFLAGS
 </xsl:text>
         </xsl:when>
         <xsl:otherwise>
-          <xsl:value-of select="$jobs"/>
-          <xsl:text>"
+          <xsl:text>export MAKEFLAGS="-j</xsl:text>
+          <xsl:choose>
+            <xsl:when test="$jobs = 0">
+              <xsl:text>$(nproc)"
 </xsl:text>
+            </xsl:when>
+            <xsl:otherwise>
+              <xsl:value-of select="$jobs"/>
+              <xsl:text>"
+</xsl:text>
+            </xsl:otherwise>
+          </xsl:choose>
         </xsl:otherwise>
       </xsl:choose>
       <xsl:choose>


HTH, even if only to point the way to a solution.

-- 
http://lists.linuxfromscratch.org/sympa/info/blfs-dev
Unsubscribe: See the above information page

diff --git a/BLFS/xsl/scripts.xsl b/BLFS/xsl/scripts.xsl
index 6c2997c..5d03658 100644
--- a/BLFS/xsl/scripts.xsl
+++ b/BLFS/xsl/scripts.xsl
@@ -193,16 +193,24 @@ export JH_KEEP_FILES="</xsl:text>
      parallel jobs. This supposes that ninja has been build with
      support for NINJAJOBS in lfs. We'll have to change that code
      if lfs changes its policy for ninja. -->
-      <xsl:text>export MAKEFLAGS="-j</xsl:text>
       <xsl:choose>
-        <xsl:when test="$jobs = 0">
-          <xsl:text>$(nproc)"
+        <xsl:when test="@id='openjdk'">
+          <xsl:text>unset MAKEFLAGS
 </xsl:text>
         </xsl:when>
         <xsl:otherwise>
-          <xsl:value-of select="$jobs"/>
-          <xsl:text>"
+          <xsl:text>export MAKEFLAGS="-j</xsl:text>
+          <xsl:choose>
+            <xsl:when test="$jobs = 0">
+              <xsl:text>$(nproc)"
 </xsl:text>
+            </xsl:when>
+            <xsl:otherwise>
+              <xsl:value-of select="$jobs"/>
+              <xsl:text>"
+</xsl:text>
+            </xsl:otherwise>
+          </xsl:choose>
         </xsl:otherwise>
       </xsl:choose>
       <xsl:choose>