Re: SDL3 needs an upstream patch to build

This is a multi-part message in MIME format...

------------=_1785703328-4183494-7556
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 8/2/26 10:26 AM, Joe Locash wrote:
> On 8/2/26 9:53 AM, Zeckma ([email protected] via blfs-dev Mailing 
> List) wrote:
>> On 8/2/26 07:35, Zeckma wrote:
>> > The problem is limited to src/core/unix/SDL_gtk.c, instead of what the
>> > patch tries to apply to: src/video/wayland/SDL_waylandvideo.c.
>> >
>> > In SDL3-3.4.12, SDL_waylandvideo.c doesn't have any getresuid stuff
>> > going on, but SDL_gtk.c does. However, upstream removed SDL_gtk.c
>> > and put in extra logic in SDL_waylandvideo.c. This logic does involve
>> > getresuid, in which the patch is then necessary as is. The SDL_gtk.c
>> > file was deleted before the getresuid issue was resolved.
>> >
>> > Thus, there are two options:
>> > 1). Fix SDL_gtk.c ourselves
>> > 2). Do what 
>> https://github.com/libsdl-org/SDL/commit/e4f75bac451230d31695158ed35f459e7a04585c
>> >     and
>> > 
>> https://github.com/libsdl-org/SDL/commit/c15b6a14578bf6544cad834473d35bf2e38ff3fd
>> >     do and remove SDL_gtk.c and fix up SDL_waylandvideo.c at the 
>> same time.
>> >
>> > I'm leaning into option 2 but we can try option 1.
>>
>> I went with option 1 since it was less work doing it that way. Fixed at
>> 98dc3c83a7d09539bf6b4049145e054314f7c5af. Thanks for letting us know! 
> The patch isn't needed. The issue was a regression in cmake-4.2.1 
> which is fixed in 4.2.2.
> See:
>   https://github.com/libsdl-org/SDL/issues/16072
>   https://gitlab.kitware.com/cmake/cmake/-/work_items/28001 
That should be cmake-4.4.1 and 4.4.2.

------------=_1785703328-4183494-7556
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0

-- 
http://lists.linuxfromscratch.org/sympa/info/blfs-dev
Unsubscribe: See the above information page
------------=_1785703328-4183494-7556--