Re: install_initd test scripts written

Andrew Josey <[email protected]>
Newsgroups gmane.linux.lsb.test-suite
Message-ID <[email protected]>
Gordon, All

Some initial comments

1.In the test code for example
wip/initd/tset/initd/install/general.sh, 
where you source in the common libraries and 
shell code you need to use the $TET_EXECUTE and $TET_ROOT 
variables rather than hard coded paths.

2. The files out.stderr and tet_xres are produced at runtime and
should not be in the source

3. The various hardcoded variables set at the start of the test case should be
set elsewhere. As such this makes it very difficult to run the tests.
Could you fix this up so its not a development effort to run the tests.

4. Are you sure that the copyright to the general.sh is solely Intel
and you did not copy that from any existing code? I notice that the
Makefile was clearly taken from copyright code I wrote, as the comment
block has been left intact.

thanks
Andrew
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.