RE: Initial patch for toolset modification proposal

"Gupta, Rita" <[email protected]> Wed, 11 Jan 2006 11:14:41 +0530
Newsgroups gmane.linux.lsb.test-suite
Message-ID <47B11D29BBB75A41A5E85352637F250090909F@bgsmsx404>
>Attached are two patches- one for the tests modules (modifying appchk
and
>libchk), the other for build-env (modifying lsbcc).
>
Haven't recvd the latest patches. Commenting based on the previous patch
u sent me and the change in nomenclature as described in this email.

>Adds the following functionality-
>If the env var LSB_PRODUCT is available, sets the default product to
the
>val- valid settings are [desktop|core], else defaults to core.
>
>Command line addition is
>-T [core|desktop], and --lsb-product [core|desktop]
>
>If defined, again, must be valid- overrides any env specification.  All
is
>an unstated product option- -A functionality is rolled in via the all
>product target (thus -A was removed).
>

Here's my understanding of argument requirements:
LSB_PRODUCT=3Dcore:     LSB_Core + Graphics + Cpp
LSB_PRODUCT=3Ddesktop:  LSB_Core + Graphics + Cpp + Graphics-Ext + XML +
GTKVTS=20
LSB_PRODUCT not set:  LSB_Core (only, no Graphics & Cpp) //this was the
behavior before desktop was introduced ...do we want to change this?
LSB_PRODUCT=3Dinvalid:  LSB_Core only (same as above)

Similarly for -T option:
-T=3Dcore             LSB_Core + Graphics + Cpp
-T=3Ddesktop          LSB_Core + Graphics + Cpp + Graphics-Ext + XML +
GTKVTS=20
-T not specified    LSB_Core only

-M option: should allow the binary (or library if -L specified) to be
checked against each individual module, irrespective of -T and
LSB_TARGET settings. To enable this, each of the desktop modules will
need a hash define in elfchk.h.

Some additional comments:
* LSB_All_Modules should set flags for each of the desktop modules
individually i.e. Graphics-Ext, XML, GTKVTS or else while looking for
symbols in the DynSyms array, the desktop symbols will be excluded.

* getmodulename & getmoduleval in elfchk.c need to be updated with the
desktop modules as the module names are logged in the journal.

* If -A option is not allowed anymore, it should be deleted from the
getopt option string "hvnAM:L:j:T:"

-regards,
 Rita