RE: [Bug 1168] libchk outputs failures for Qt classes withinheritance

"Wichmann, Mats D" <[email protected]> Tue, 24 Jan 2006 13:31:59 -0800
Newsgroups gmane.linux.lsb.test-suite
Message-ID <A06801158AE07847B27A52C1A074BC1D099F9693@fmsmsx404.amr.corp.intel.com>
>This patch fixes a bunch of the failures I'm getting, can=20
>someone review it?=20
>=20
>Index: classchk.c=20
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=20
>RCS file: /cvsroot/lsb/tests/misc/libchk/classchk.c,v=20
>retrieving revision 1.54=20
>diff -u -3 -p -r1.54 classchk.c=20
>--- classchk.c  17 Jan 2006 16:41:38 -0000      1.54=20
>+++ classchk.c  24 Jan 2006 14:07:32 -0000=20
>@@ -480,7 +480,7 @@ check_class_info(ElfFile * file, char *l=20
>               si_rttip->basetype, dlainfo.dli_sname);=20
>          test_failed =3D 1;=20
>        }=20
>-       basetypes =3D si_rttip->basetypeinfo;=20
>+        basetypes =3D rttip->basetypeinfo;=20
> /*     if( classp->numbaseinfo ) */=20
> /*       fprintf(stderr,"si_class_type_info & baseinfos\n"); */=20
>       }   =20


there's really only one person with detailed enough
knowledge to know why it was the way it was and
not the way you suggest (i.e., mistake or intentional),
and that's Stuart.

to me it looks reasonable.