Re: [PATCH v8] cpufreq.c: add new test for cpufreq sysfs interface validation
Cyril Hrubis <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi! > + SAFE_FILE_SCANF(path, "%255s", contents); > + tst_res(TDEBUG, "Checking whether %s is \"intel_pstate\"", path); I slightly prefer single quotes inside double quotes e.g. " ... 'intel_pstate'" since they does not need to be escaped. And maybe the run() could have been split into functions so that it's not that long. But both of these are very minor. Reviewed-by: Cyril Hrubis <[email protected]> -- Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp