Hi Andrea,
On Fri, 5 Jun 2026 11:17:13 +0200, Andrea Cervesato <andrea.cervesato-IBi9RG/[email protected]> wrote:
> [PATCH] doc: Add missing API references to api_c_tests.rst
--- [PATCH 1/3] ---
> Fixes: eef750db28 ("libs: adopt tse_ prefix for extended (non-core) library")
The commit eef750db28 referenced in the Fixes tag does not exist in the
LTP git history. Is the commit hash correct?
--- [PATCH 2/3] ---
> doc: Complete struct tst_test table and shell API docs
>
> Add 8 missing struct tst_test fields to the C/Shell API comparison
> table in writing_tests.rst: .filesystems, .forks_child, .min_runtime,
> .needs_abi_bits, .needs_cgroup_nsdelegate, .needs_cgroup_ver,
> .needs_hugetlbfs and .runs_script, and fix the alphabetical ordering
> of .mnt_flags and .min_swap_avail.
>
> Add a shell API variables reference section to api_shell_tests.rst
> documenting all public TST_* input/output variables, checkpoint
> functions, and retry helpers.
The commit body describes what changed, but does not explain why the change
is needed. Could you provide a motivation for the change?
Verdict: Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.