Re: ksm: Fix sysfs path concatenation in ksm_test.h
Cyril Hrubis <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi!
> On Mon, 8 Jun 2026 07:44:15 +0000, Wei Gao wrote:
> > ksm: Fix sysfs path concatenation in ksm_test.h
>
> > Fixes: 40a366b53adc ("lib: Introduce tst_path_defs.h to consolidate system paths")
>
> This commit hash does not exist in the LTP repository. Could the
> reference be verified and corrected?
>
> Verdict: Needs revision
@Andrea the bot still misses existing patches:
$ git log 40a366b53adc
commit 40a366b53adc477d950cc73f071b0cd4ebe25f85
Author: Li Wang <[email protected]>
Date: Thu Jun 4 17:41:59 2026 +0800
lib: Introduce tst_path_defs.h to consolidate system paths
We have a lot of hardcoded strings and duplicated macros for /proc
and /sys paths scattered throughout the testcases.
This patch introduces a new common header, tst_path_defs.h, to centralize
and standardize these path definitions. By unifying these macros, we
reduce code duplication, improve maintainability, and ensure consistent
path usage across the entire LTP codebase.
Signed-off-by: Li Wang <[email protected]>
Acked-by: Andrea Cervesato <andrea.cervesato-IBi9RG/[email protected]>
Reviewed-by: Cyril Hrubis <[email protected]>
--
Cyril Hrubis
[email protected]
--
Mailing list info: https://lists.linux.it/listinfo/ltp