Re: [PATCH v5 2/2] firmware/fw_load: add fw_load02 for custom firmware path

Hi Cyril,

> > +	/*
> > +	 * Point the kernel firmware loader at our writable tmpdir so the
> > +	 * test does not depend on a writable /lib/firmware. The previous
> > +	 * value is restored automatically during cleanup.
> > +	 */
> > +	tst_sys_conf_save(&fw_path);
> 
> I would say that it's cleaner to add the save_restore to the tst_test
> structure without the tmpdir value and use
> SAFE_FILE_PRINTF(FW_PATH, "%s", tmpdir) in the test setup. Since if the
> test crashes the test library will still restore the FW_PATH

The problem here is that we have to use the tmpdir for the custom
folder, because on immutable distribution fw_path will be read-only.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato-IBi9RG/[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp