Re: [PATCH v5 1/2] firmware/fw_load: rewrite firmware loading test using new LTP API
Cyril Hrubis <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi!
> > > runtest/kernel_misc | 2 +-
> > > .../{fw_load_kernel => fw_load}/.gitignore | 1 +
> > > .../firmware/{fw_load_kernel => fw_load}/Makefile | 8 +-
> > > testcases/kernel/firmware/fw_load/fw_load.h | 18 ++
> > > testcases/kernel/firmware/fw_load/fw_load01.c | 165 ++++++++++++++++
> > > .../{fw_load_kernel => fw_load}/ltp_fw_load.c | 0
> > > testcases/kernel/firmware/fw_load_user/.gitignore | 1 -
> > > testcases/kernel/firmware/fw_load_user/Makefile | 20 --
> > > testcases/kernel/firmware/fw_load_user/README | 11 --
> > > testcases/kernel/firmware/fw_load_user/fw_load.c | 213 ---------------------
> >
> > This is impossible to review. If you move/rename files it's usually done
> > in a separate patch that does not change the content.
>
> I usually review with double column editor left=old, right=new :-)
> But I agree with you that diff is messed up. Should I send a new
> version?
Yes, please.
--
Cyril Hrubis
[email protected]
--
Mailing list info: https://lists.linux.it/listinfo/ltp