Re: pipe15: add min kver v4.4.281

On Fri, 12 Jun 2026 at 02:22, <[email protected]> wrote:

> Hi Po-Hsu,
>
> On Fri, Jun 12, 2026, Po-Hsu Lin wrote:
> > pipe15: add min kver v4.4.281
>
> > This patch 46c4c9d1beb7 has been backported to stable v4.4 with
> > commit 7392701d8615 on linux-4.4.y starting from tag v4.4.281 [1]
>
> "This patch 46c4c9d1beb7" is ambiguous. In the context of a patch
> submission, "this patch" reads as if it refers to the current LTP
> patch. Something like "Upstream commit 46c4c9d1beb7 has been
> backported..." would be clearer.
>
> Also, the body describes the fact that a backport happened but does
> not explain *why* adding min_kver to pipe15 is needed. What problem
> does this solve? Does the test TBROK on older 4.4.x kernels because
> /proc/sys/fs/pipe-user-pages-soft is missing? Or does it hang
> because the fix is absent?
>
> If the sysctl was never present on 4.4.x before 4.4.281, then the
> min_kver is legitimate feature gating and the commit message should
> say so. If the sysctl did exist but the hang fix was missing, then
> skipping the test would mask the bug on those kernels, which
> conflicts with the LTP policy of not working around kernel bugs.
>
> I can confirm that this sysctl, /proc/sys/fs/pipe-user-pages-soft, that
the test is trying to access exists on 4.4.x before 4.4.281.

Please ignore this patch.
Thanks.



> Verdict: Needs revision
>
> Pre-existing: the tags array at line 95 is missing the required
> {} null terminator (see tst_test.h: "@tags: A {} terminated
> array").
>
> ---
> Note:
>
> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.
>
> Regards,
> LTP AI Reviewer
>

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp