Re: fs/acl: Add ACL_USER_OBJ permission test

Hi Sachin,

On Sat Jun 13 14:35:36 2026 +0530, Sachin Sant wrote:
> fs/acl: Add ACL_USER_OBJ permission test

--- [PATCH 1/8] ---

> + * to files and directories. The test validates that:
> + * - ACL_USER_OBJ permissions are applied directly as the owner bits

RST requires a blank line before a bulleted list, otherwise the
list items are parsed as continuation of the preceding paragraph.
Could a blank ` *` line be inserted after "that:"?

--- [PATCH 2/8] ---

> + * For each entry type (ACL_USER, ACL_GROUP, ACL_GROUP_OBJ):
> + * - Set up ACL with full permissions for the entry

Same RST issue here -- a blank ` *` line is needed between the
introductory sentence and the first list item.

--- [PATCH 5/8] ---

> + * Test 1 - :manpage:`chmod(2)` interaction:
> + * - Create file with read-only ACL entries

Missing blank ` *` line before the list.

> + * Test 2 - :manpage:`chown(2)` interaction:
> + * - Create file with specific ACL entries (rw for user, r for group/other)

Same here.

--- [PATCH 7/8] ---

> +	if (removexattr(TESTFILE, XATTR_TEST_FILE_NAME) == -1) {
> +		tst_res(TFAIL | TERRNO, "removexattr failed");

removexattr() is part of the tested functionality and should be
wrapped in TEST(), e.g.:

  TEST(removexattr(TESTFILE, XATTR_TEST_FILE_NAME));
  if (TST_RET == -1) {
      tst_res(TFAIL | TTERRNO, "removexattr failed");

> +	size = getxattr(TESTFILE, XATTR_TEST_FILE_NAME, value,
> +			sizeof(value));
> +	if (size >= 0 || errno != ENODATA) {

This verifies that removal took effect and checks for a specific
errno, so it should also use TEST() and TST_ERR instead of errno
directly, e.g.:

  TEST(getxattr(TESTFILE, XATTR_TEST_FILE_NAME, value,
                sizeof(value)));
  if (TST_RET >= 0 || TST_ERR != ENODATA) {

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp