| Newsgroups |
gmane.linux.ltp |
| Message-ID |
<[email protected]> |
Hi Wei,
On Tue, 16 Jun 2026, Wei Gao <wegao-IBi9RG/[email protected]> wrote:
> connect01: Convert to new API
--- [PATCH 1/2] ---
> + SAFE_CLOSE(fd_server);
> + fd_server = -1;
SAFE_CLOSE() already resets its argument to -1. The manual
assignment is redundant and can be dropped.
--- [PATCH 2/2] ---
> connect01: Add negative tests
>
> Add negative cases for connect(), when errno is EPROTOTYPE or EACCES.
The body restates the subject. Could it say why these specific
error paths are worth covering now? e.g. "These error paths were
not exercised by the existing test."
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp