Re: [PATCH 4/5] fanotify21: Add test variants for FAN_REPORT_TID

Hi Jan,

> Hello!
> 
> On Tue 16-06-26 08:24:33, Andrea Cervesato wrote:
> > the patch-set is failing to compile on our CI. Please send a new
> > version fixing it:
> > 
> > https://github.com/linux-test-project/ltp/actions/runs/27572447779/job/81512172691
> 
> Hum, I had a look and the failure actually is:
> 
> parse_opts.c: In function 'usc_test_looping':
> parse_opts.c:521:3: warning: call to function 'usc_recressive_func' without a real prototype [-Wunprototyped-calls]
>    usc_recressive_func(0, STD_LP_recfun, *STD_bigstack);
>    ^
> parse_opts.c:107:13: note: 'usc_recressive_func' was declared here
>  static void usc_recressive_func();
>              ^
> CC libs/numa/tse_numa.o
> AR libltpnuma.a
> RANLIB libltpnuma.a
> CC lib/random_range.o
> CC lib/parse_opts.o
> CC lib/safe_file_ops.o
> In file included from ../../include/tse_sigwait.h:11:0,
>                  from tse_sigwait.c:8:
> ../../include/tst_timer.h: In function 'tst_ts_from_timespec':
> ../../include/tst_timer.h:626:3: warning: missing initializer for field 'tv_nsec' of 'struct timespec' [-Wmissing-field-initializers]
>    .ts.libc_ts.tv_nsec = ts.tv_nsec,
>    ^
> In file included from /usr/include/sys/select.h:43:0,
>                  from /usr/include/sys/types.h:219,
>                  from /usr/include/stdlib.h:314,
>                  from tse_sigwait.c:6:
> /usr/include/time.h:123:23: note: 'tv_nsec' declared here
>      __syscall_slong_t tv_nsec; /* Nanoseconds.  */
>                        ^
> CC lib/safe_pthread.o
> 
> So I'm a bit at loss what change in fanotify tests could have caused a
> failure in compilation of the generic LTP library code? Any idea?
> 
> 								Honza
> -- 
> Jan Kara <jack-IBi9RG/[email protected]>
> SUSE Labs, CR

Those are warnings caused by old GCC. It's possible to fix them
by changing the explicit struct initialization with a 2 step init
such as:

struct mystruct s;
s.item0 = i1;
s.item1 = i2;

The real issue is that fanotify21 needs to link pthread:

-fanotify11: CFLAGS+=-pthread
+fanotify11 fanotify21: CFLAGS+=-pthread

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato-IBi9RG/[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp