Re: [PATCH v15 2/2] futex_cmp_requeue03: Add EFAULT error coverage test

Andrea Cervesato via ltp <[email protected]>
Newsgroups gmane.linux.ltp
Message-ID <[email protected]>
Hi Michael,

the patch LGTM, but agent is right: we are missing a unaccessible
memory test for addr2.

   {
       .desc = "uaddr2 PROT_NONE",
       .uaddr = &futex_ptr,
       .uaddr2 = &prot_none_addr,
       .exp_errno = EFAULT,
   },

The test description is mentioning this check but there's no trace
of it inside test code.

Please send a follow-up patch, then we can merge it if no issues
will pop up.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato-IBi9RG/[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.