Re: [PATCH 06/13] mem/ksm05: Add proper runtime support

Hi!
> >  static void sighandler(int sig)
> > @@ -91,7 +95,8 @@ static void sighandler(int sig)
> >  static struct tst_test test = {
> >  	.needs_root = 1,
> >  	.forks_child = 1,
> > -	.test_all = test_ksm,
> > +	.test_all = run,
> > +	.min_runtime = 10,
> 
> Even if this is technically correct, I'm not 100% sure about it.
> Now if we want to manually test the binary, we have to wait 10
> seconds by default, while before we had to explicitly use -I.

I would say that the defaults should be geared towards testing not
development. If a test needs 10 seconds to trigger the bug, the default
run without any parameters should run for 10 seconds.

-- 
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp