Re: [PATCH 05/13] vma05.sh, keyctl01.sh: Add groups
Cyril Hrubis <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi! > > I fear that we will have a lot of typos and wrong data in there. We had > > quite a few wrong CVE tags already, because we weren't checking them for > > validity. > > > > I'm okay with this as long as we have a checks in 'make check' that make > > sure that the manually assigned groups are correct. For that we would > > need the same heuristic we have for automatic groups to check that we > > didn't miss anything and a list of valid groups to check againts to > > guard againts typos. > > Don't forget we also have the agent that works quite good on these > small tasks. We can add a rule and make sure they are always valid > groups. Honestly I'm not 100% convinced that the agent would spot all issues, maybe it would maybe it wouldn't but would you trust it will? Also linter should be cheaper and pretty easy for this case. -- Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp