Re: [PATCH v3] set_mempolicy: require CONFIG_NUMA

On Fri, Jun 26, 2026 at 03:53:46PM +0200, Avinesh Kumar via ltp wrote:
> From: Avinesh Kumar <avinesh.kumar-IBi9RG/[email protected]>
> 
> On kernels without CONFIG_NUMA=y set_mempolicy() returns ENOSYS,
> which the test misreports as TFAIL.
> 
> set_mempolicy05 -
> 
> set_mempolicy05.c:105: TFAIL: set_mempolicy should fail with EFAULT or EINVAL, instead returned 38
> 
> remaining of these tests (set_mempolicy[01-04]) checks for minimum two
> NUMA nodes and reports TCONF, but those also should exit on CONFIG_NUMA
> check.
> 
> tse_numa.c:200: TINFO: Found 1 NUMA memory nodes
> tse_numa.c:141: TINFO: File '/sys/devices/system/node/node0/meminfo' does not exist! NUMA not enabled?
> get_mempolicy02.c:60: TCONF: test requires at least one NUMA memory node
> 
> Add .needs_kconfigs with CONFIG_NUMA=y
> 
> Signed-off-by: Avinesh Kumar <avinesh.kumar-IBi9RG/[email protected]>
> ---
>  testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c | 4 ++++
>  testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c | 4 ++++
>  testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c | 4 ++++
>  testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c | 4 ++++
>  testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c | 4 ++++
>  5 files changed, 20 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c
> index a85a56332..07836cc69 100644
> --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c
> +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy01.c
> @@ -120,6 +120,10 @@ static struct tst_test test = {
>  	.forks_child = 1,
>  	.needs_checkpoints = 1,
>  	.timeout = 600,
> +	.needs_kconfigs = (const char *const[]){
> +		"CONFIG_NUMA=y",
> +		NULL
> +	}
>  };
I suppose we do not need "#ifdef HAVE_NUMA_V2" anymore in the code.
Same for set_mempolicy02 etc
>  
>  #else
> diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c
> index 94d8aa336..d98f81545 100644
> --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c
> +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy02.c
> @@ -109,6 +109,10 @@ static struct tst_test test = {
>  	.tcnt = 2,
>  	.forks_child = 1,
>  	.needs_checkpoints = 1,
> +	.needs_kconfigs = (const char *const[]){
> +		"CONFIG_NUMA=y",
> +		NULL
> +	}
>  };
>  
>  #else
> diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c
> index bc5e03217..43e0439d4 100644
> --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c
> +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy03.c
> @@ -103,6 +103,10 @@ static struct tst_test test = {
>  	.mntpoint = MNTPOINT,
>  	.forks_child = 1,
>  	.needs_checkpoints = 1,
> +	.needs_kconfigs = (const char *const[]){
> +		"CONFIG_NUMA=y",
> +		NULL
> +	}
>  };
>  
>  #else
> diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c
> index 672232c84..fa88385ce 100644
> --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c
> +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy04.c
> @@ -134,6 +134,10 @@ static struct tst_test test = {
>  	.all_filesystems = 1,
>  	.mntpoint = MNTPOINT,
>  	.needs_checkpoints = 1,
> +	.needs_kconfigs = (const char *const[]){
> +		"CONFIG_NUMA=y",
> +		NULL
> +	}
>  };
>  
>  #else
> diff --git a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
> index 7481dcd8d..fb118c4ac 100644
> --- a/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
> +++ b/testcases/kernel/syscalls/set_mempolicy/set_mempolicy05.c
> @@ -115,6 +115,10 @@ static struct tst_test test = {
>  		"ppc",
>  		NULL
>  	},
> +	.needs_kconfigs = (const char *const[]){
> +		"CONFIG_NUMA=y",
> +		NULL
> +	},
>  	.tags = (const struct tst_tag[]) {
>  		{"linux-git", "cf01fb9985e8"},
>  		{"CVE", "2017-7616"},
> -- 
> 2.54.0
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp