Re: [PATCH v1] statx/statx04: Skip testing casefolded filesystems
Wei Gao via ltp <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
O
Thu, Jul 02, 2026 at 11:48:47AM +0000, Andrea Cervesato via ltp wrote:
> > if (!strcmp(tst_device->fs_type, "vfat") || !strcmp(tst_device->fs_type, "exfat"))
> > expected_mask &= ~(STATX_ATTR_APPEND | STATX_ATTR_IMMUTABLE | STATX_ATTR_NODUMP);
I guess we also need exclude STATX_ATTR_COMPRESSED?
expected_mask &= ~(STATX_ATTR_APPEND | STATX_ATTR_IMMUTABLE | STATX_ATTR_NODUMP | STATX_ATTR_COMPRESSED);
But when we do this, meaning the test runs but verifies nothing, just
TCONF is more clean.
>
> One more thing: this is a snippet. Remember that we also need to filter
> out the right kernel version, which is the v7.1 at this point, since it
> has been released.
Adding a kernel version check with tst_kvercmp(7, 1, 0) is redundant here. Here is why:
On kernels < v7.1:
vfat/exfat do not support FS_IOC_GETFLAGS at all. The ioctl() call fails with ENOTTY, and the test is immediately skipped with TCONF at the beginning of setup():
if (TST_RET == -1 && TST_ERR == ENOTTY)
tst_brk(TCONF | TTERRNO, "Inode attributes not supported");
So i suggest we just give fix like following, do you agree?
if (!strcmp(tst_device->fs_type, "vfat") || !strcmp(tst_device->fs_type, "exfat"))
tst_brk(TCONF, "vfat and exfat filesystems do not support standard attributes");
>
> --
> Andrea Cervesato
> SUSE QE Automation Engineer Linux
> andrea.cervesato-IBi9RG/[email protected]
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Mailing list info: https://lists.linux.it/listinfo/ltp