Hi Andrea,
On Mon, 7 Jul 2026, Andrea Cervesato wrote:
> landlock: fix make check warnings/errors
> - if (errno == EOPNOTSUPP) {
> - tst_brk(TCONF, "Landlock is currently disabled. "
> - "Please enable it either via CONFIG_LSM or "
> - "'lsm' kernel parameter.");
> - }
> + if (errno == EOPNOTSUPP)
> + tst_brk(TCONF, "Landlock is currently disabled. Please enable it either via CONFIG_LSM or 'lsm' kernel parameter.");
The new line in landlock_common.h is ~132 characters long. The
original multi-line string had an alignment warning, but this hunk
trades it for a line-over-80-characters warning, which checkpatch
will still flag.
Could the string be re-wrapped to satisfy the line-length limit,
for example:
if (errno == EOPNOTSUPP)
tst_brk(TCONF,
"Landlock is currently disabled. Please "
"enable it either via CONFIG_LSM or "
"'lsm' kernel parameter.");
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.