Hi Jinseok,
On Tue, 07 Jul 2026 16:31:02 +0000, Jinseok Kim wrote:
> syscalls: Replace getppid02 with getpid02 implementation
> Remove the existing getppid02.c as its coverage is overlapped by
> getpid02.c. Then, replace it by renaming and adapting the broader checks
> from getpid02.c to serve as the new getppid02.c.
The commit message says "Remove the existing getppid02.c" but the file
that is actually deleted is getpid02.c. getppid02.c is replaced, not
removed. The sentence reads as if getppid02.c disappears, which is the
opposite of what happens.
> +static void verify_getpid(void)
This function is in getppid02.c but the name still says `verify_getpid`.
The function tests both fork/getpid consistency and getppid correctness,
but it was copied from getpid02.c without renaming. Could it be renamed
to `verify_getppid` to match the file it now lives in?
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.