Hi Petr,
On Fri, 10 Jul 2026 07:55:49 +0200, Petr Vorel wrote:
> Makefile: Skip test-metadata on cross compile
--- [PATCH 2/8] ---
> + printf "* $i "
$i is used directly as part of the printf format string rather than
passed as a separate argument. A filename containing a '%' character
would be interpreted as a format specifier.
The portable form is:
printf "* %s " "$i"
--- [PATCH 4/8] ---
> + $METAPARSE $i > tmp.json
Both $METAPARSE and $i are unquoted. If METAPARSEDIR (and therefore
METAPARSE) contains spaces, the shell will perform word-splitting on
the variable before exec, breaking the invocation.
The quoted form:
"$METAPARSE" "$i" > tmp.json
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.