Re: [PATCH v3 3/9] syscalls: Add epoll_wait09

Cyril Hrubis <[email protected]>
Newsgroups gmane.linux.ltp
Message-ID <[email protected]>
Hi!
> > +
> > +#include <sys/epoll.h>
> > +
> > +#include "tst_epoll.h"
> > +#include "tst_test.h"
> > +
> > +#define MAX_DEPTH 5
> > +
> > +static int epfds[MAX_DEPTH];
> > +static int fds[2] = {-1, -1};
> > +
> > +static struct tcase {
> > +	int depth;
> > +} tcases[] = {
> > +	{2},
> > +	{3},
> > +	{4},
> > +	{5},
> 
> nit: why not just define depth in the test?
> int depth = n + 2;
> 
> And
> -	.tcnt = ARRAY_SIZE(tcases),
> +	.tcnt = MAX_DEPTH,

Done, however this has to be MAX_DEPTH-1,
since we are starting at depth 2.

> Also, could you run make check to fix formatting complains?

Also done.

And pushed, thanks.

-- 
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.