Re: [PATCH v4] sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.
Andrea Cervesato via ltp <[email protected]> Tue, 28 Jul 2026 13:32:33 +0000
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi Samir, > Link: https://lore.kernel.org/ltp/20260407062336.127454-1-samir-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org/ #v1 > Link: https://lore.kernel.org/ltp/20260412122842.1074017-1-samir-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org/ #v2 > Link: https://lore.kernel.org/ltp/20260602095656.404290-1-samir-tEXmvtCZX7AybS5Ee8rs3A@public.gmane.org/ #v3 This should never be part of the commit message, but stay in the `---` section below. The rest LGTM, but you have missed a couple of warnings: CHECK testcases/kernel/sched/cfs-scheduler/hackbench.c hackbench.c:82: WARNING: Prefer using '"%s...", __func__' to using 'fdpair', this function's name, in a string hackbench.c:93: WARNING: Prefer using '"%s...", __func__' to using 'ready', this function's name, in a string hackbench.c:310: WARNING: Prefer using '"%s...", __func__' to using 'main', this function's name, in a string -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato-IBi9RG/[email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp