Re: [PATCH v12 1/8] fs/acl: Add ACL_USER_OBJ permission test
Sachin Sant <[email protected]> Wed, 29 Jul 2026 19:22:31 +0530
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
On 29/07/26 5:54 pm, Cyril Hrubis wrote:
> Hi!
> I've cleaned up the patchset and pushed all the acl_* tests, thanks.
>
> We already have xattr tests in syscalls/{set,get}_xattr that cover basic
> xattr operations I haven't xattr_test01 for that reason. If coverage is
> lacking there the xattr tests should be put there.
Thank you.
> The main changes:
>
> Added SAFE_ACL_SET_FILE() since the code to handle EOPNOTSUPP was
> repeated in each test. I've also weeded out some of the cleanup, there
> is no point in unlinking files or freeing memory before we call
> tst_brk() since that will be handled by the test cleanup and OS process
> memory teardown.
>
> Also weeded out the file removal in various branches in the middle of
> the test and in the test setup(). Each test cleans up the files at the
> start of the test function. With that there is no point in doing the
> cleanup anywhere else but cleanup().
>
--
Thanks
- Sachin
--
Mailing list info: https://lists.linux.it/listinfo/ltp