Re: [PATCH 1/2] sctp: add lapi fallback definitions

Hi: Andrea,

> +/* SCTP wire format values, see include/linux/sctp.h in the kernel */
+1 for that comment.

> +#ifndef SCTP_CID_INIT
> +# define SCTP_CID_INIT		1
> +#endif
> +
> +#ifndef SCTP_CID_INIT_ACK
> +# define SCTP_CID_INIT_ACK	2
> +#endif
> +
> +#ifndef SCTP_CID_ASCONF_ACK
> +# define SCTP_CID_ASCONF_ACK	0x80
> +#endif
> +
> +#ifndef SCTP_CID_ASCONF
> +# define SCTP_CID_ASCONF		0xc1
> +#endif
> +
> +#ifndef SCTP_PARAM_IPV4_ADDRESS
> +# define SCTP_PARAM_IPV4_ADDRESS	5
> +#endif
> +
> +#ifndef SCTP_PARAM_DEL_IP
> +# define SCTP_PARAM_DEL_IP	0xc002
> +#endif
> +
> +#ifndef SCTP_PARAM_ERR_CAUSE
> +# define SCTP_PARAM_ERR_CAUSE	0xc003
I hope cpu_to_be16(0xc003) is really on all supported archs 0xc003 :).

Anyway, the rest LGTM.
Reviewed-by: Petr Vorel <[email protected]>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp