[PATCH v4 0/3] Handle FORCE_PTRACE in thp04 and add ptrace coverage
Jan Polensky <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
thp04 is a CVE-2017-1000405 regression test. If direct /proc/self/mem writes are blocked by CONFIG_PROC_MEM_FORCE_PTRACE=y, the CVE cannot be triggered and thp04 should report TCONF. Add separate ptrace tests for the CONFIG_PROC_MEM_FORCE_PTRACE behavior instead: - ptrace12 checks that writing to /proc/self/mem is rejected with EIO. - ptrace13 checks that a parent can write to a traced child's memory via /proc/pid/mem. Both ptrace tests use read-only mappings, so the writes require FOLL_FORCE and exercise the CONFIG_PROC_MEM_FORCE_PTRACE enforcement. Tested on s390x with CONFIG_PROC_MEM_FORCE_PTRACE=y: - thp04: TCONF (direct /proc/self/mem writes blocked) - ptrace12: TPASS - ptrace13: TPASS, 100 iterations Follow-up to the previous thp04 ptrace mode discussion: https://lore.kernel.org/all/[email protected]/ Changes in v4: - thp04: prove the /proc/self/mem probe changes memory before running the race - thp04: tighten direct-write result handling and document blocked-write behavior - ptrace12: gate the test on CONFIG_PROC_MEM_FORCE_PTRACE=y - ptrace12: treat successful /proc/self/mem writes as TFAIL under the required config - ptrace13: use a tracer-controlled PTRACE_INTERRUPT initial stop - ptrace13: fix the iteration diagnostic and clean up wait-status handling - ptrace13: use PTRACE_KILL for normal termination Changes in v3: - All patches: Fixed RST doc formatting (added blank lines before lists) - All patches: Removed redundant comments per LTP coding style - thp04: Removed comments restating pointer arithmetic - ptrace12: Kept only intent-focused FOLL_FORCE comment - ptrace13: Removed unused shared_state.result field - ptrace13: Removed misleading "previous iteration" comment - ptrace13: Clarified iteration counter in TFAIL message to show which write is being verified - ptrace13: Kept only intent-focused FOLL_FORCE comment and synchronization pattern comment Changes in v2: - thp04: Removed .forks_child flag (not needed without actual fork) - thp04: Changed MAP_SHARED to MAP_PRIVATE for child state mapping - thp04: Added missing #include <string.h> for memset() - thp04: Renamed struct child_state → struct thp_state (no longer uses fork) - thp04: Renamed child → state, child_setup() → thp_setup(), child_cleanup() → thp_cleanup() - ptrace12: Removed deprecated [Description] line from doc block - ptrace12: Replaced bare write() with TEST() macro, using TST_RET/TST_ERR - ptrace12: Adjusted setup comment to clarify page initialization sequence - ptrace13: Removed deprecated [Description] line from doc block - ptrace13: Added missing #include <string.h> for memset() - Both ptrace tests: Added to runtest/syscalls v3: https://lore.kernel.org/all/[email protected]/ v2: https://lore.kernel.org/all/[email protected]/ v1: https://lore.kernel.org/all/[email protected]/ Jan Polensky (3): thp04: group runtime state and skip when /proc/self/mem writes are blocked ptrace: add test for /proc/self/mem write rejection ptrace: add test for /proc/pid/mem writes under ptrace runtest/syscalls | 2 + testcases/kernel/mem/thp/thp04.c | 179 ++++++++++++----- testcases/kernel/syscalls/ptrace/.gitignore | 2 + testcases/kernel/syscalls/ptrace/ptrace12.c | 95 +++++++++ testcases/kernel/syscalls/ptrace/ptrace13.c | 202 ++++++++++++++++++++ 5 files changed, 428 insertions(+), 52 deletions(-) create mode 100644 testcases/kernel/syscalls/ptrace/ptrace12.c create mode 100644 testcases/kernel/syscalls/ptrace/ptrace13.c base-commit: 0b69550e055b5385822f001e2a27fedfbef31816 prerequisite-patch-id: 478e6be646f4717e084dd1eec187665b854ea028 prerequisite-patch-id: 16fc00d302aefbf6fb17e972a4390341bfbb0e50 prerequisite-patch-id: 6e77ef09b2259daae915f4a4895bf0879b7b7211 prerequisite-patch-id: 1d13f676c1c1b9b37e97b1e18ae75611a3516f96 prerequisite-patch-id: 11b8f2b102029b41838899f2a78132b50cac12a0 prerequisite-patch-id: 811e85d9a4158f72559de5f551ad93f109362c96 -- 2.55.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp