Re: [PATCH v2 1/5] fanotify20: Skip FAN_REPORT_PIDFD | FAN_REPORT_TID test on v7.2+

Hi all,

> On Wed 17-06-26 05:04:44, AnonymeMeow wrote:
> > fanotify_init() used to reject FAN_REPORT_PIDFD combined with
> > FAN_REPORT_TID with EINVAL. Since Linux v7.2, fanotify supports
> > reporting pidfds for thread IDs, so this combination is expected to
> > succeed.

> > Signed-off-by: AnonymeMeow <[email protected]>

> Looks good. Feel free to add:

> Reviewed-by: Jan Kara <[email protected]>

In the end, after some iterations trying to add .max_kver, this simple version
was merged.

Thanks to all for their time.

Kind regards,
Petr

> 								Honza

> > ---
> >  testcases/kernel/syscalls/fanotify/fanotify20.c | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)

> > diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c
> > index b32ecf6aa..f395d77ee 100644
> > --- a/testcases/kernel/syscalls/fanotify/fanotify20.c
> > +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c
> > @@ -8,13 +8,15 @@

> >  /*\
> >   * This source file contains a test case which ensures that the
> > - * :manpage:`fanotify(7)` API returns an expected error code when provided an
> > - * invalid initialization flag alongside FAN_REPORT_PIDFD. Additionally, it
> > - * checks that the operability with existing FAN_REPORT_* flags is maintained
> > - * and functioning as intended.
> > + * :manpage:`fanotify(7)` API returns an expected error code when provided
> > + * unsupported initialization flags, e.g. FAN_REPORT_PIDFD combined with
> > + * FAN_REPORT_TID. Additionally, it checks that the operability with
> > + * supported FAN_REPORT_* flags is maintained and functioning as intended.
> >   *
> >   * NOTE: FAN_REPORT_PIDFD support was added in v5.15-rc1 in
> >   * af579beb666a ("fanotify: add pidfd support to the fanotify API").
> > + * FAN_REPORT_PIDFD combined with FAN_REPORT_TID is supported since v7.2-rc1
> > + * in 17171128513b ("fanotify: report thread pidfds for FAN_REPORT_TID").
> >   */

> >  #define _GNU_SOURCE
> > @@ -45,6 +47,10 @@ static struct test_case_t {

> >  static void do_setup(void)
> >  {
> > +	if (tst_kvercmp(7, 2, 0) >= 0)
> > +		tst_brk(TCONF, "FAN_REPORT_PIDFD | FAN_REPORT_TID is supported "
> > +			       "since v7.2, skipping test");
> > +
> >  	/*
> >  	 * An explicit check for FAN_REPORT_PIDFD is performed early on in the
> >  	 * test initialization as it's a prerequisite for all test cases.
> > -- 
> > 2.54.0

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp