Re: [PATCH] openposix: Remove timer_*/speculative tests for invalid timerid
Avinesh Kumar via ltp <[email protected]>
| Newsgroups | gmane.linux.ltp |
|---|---|
| Message-ID | <[email protected]> |
Hi Cyril, Andrea,
Thanks for the review and suggesting alternative approach.
> Hi!
>> This is the problem with POSIX systems.. I would suggest to keep them
>> and simply ignore them if running on Linux. Do we have a mechanism for that
>> or we should do it at runner level?
>
> I guess that we can simply #ifndef __linux__ these.
>
If we agree on this, I can send revised patch as suggested for all the
tests under conformance/interfaces/timer_[delete|getoverrun|gettime|
settime]/speculative/
---
a/testcases/open_posix_testsuite/conformance/interfaces/timer_delete/speculative/5-1.c
+++
b/testcases/open_posix_testsuite/conformance/interfaces/timer_delete/speculative/5-1.c
@@ -19,6 +19,11 @@
int test_main(int argc PTS_ATTRIBUTE_UNUSED, char **argv
PTS_ATTRIBUTE_UNUSED)
{
+#ifdef __linux__
+ printf("Linux does not implement this optional behavior\n");
+ return PTS_UNSUPPORTED;
+#else
timer_t tid;
int tval = BOGUSTIMERID;
tid = (timer_t) & tval;
@@ -37,4 +42,5 @@ int test_main(int argc PTS_ATTRIBUTE_UNUSED, char
**argv PTS_ATTRIBUTE_UNUSED)
printf("timer_delete() did not return -1\n");
return PTS_PASS;
+#endif
--
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp