Re: sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.

Samir M <[email protected]>
Newsgroups gmane.linux.ltp
Message-ID <[email protected]>
On 18/08/26 11:04 pm, [email protected] wrote:
> Hi Samir,
>
> On Tue, Aug 18, 2026, Samir Mulani wrote:
>> sched/cfs-scheduler: Fix 'make check' errors and warnings in hackbench.c.
>> Fix all 'make check' warnings in hackbench.c to comply with the LTP
>> coding style guidelines.
> [Minor] Could create_worker() and reap_worker() be made static, or could the
> claim above be narrowed? The affected directory's make check still reports
> that both symbols have no prototype or library prefix and asks whether they
> should be static.


Thanks for pointing this out. Both |create_worker()| and |reap_worker()| 
are only used within |hackbench.c|, so I'll make them static in the next 
revision.

> Verdict - Needs revision
>
> ---
> Note:
>
> The agent can sometimes produce false positives although often its
> findings are genuine. If you find issues with the review, please
> comment this email or ignore the suggestions.
>
> Regards,
> LTP AI Reviewer
>
Regards,
Samir

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.