main - vgimport: invalidate hints

David Teigland <[email protected]>
Newsgroups gmane.linux.lvm.devel
Message-ID <[email protected]>
Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=25cb6a042fab1af7ea4f4a164771a810e1acdef5
Commit:        25cb6a042fab1af7ea4f4a164771a810e1acdef5
Parent:        0f6da9926d0e7be66e759c27f42baf0c414c1ff8
Author:        David Teigland <[email protected]>
AuthorDate:    Wed Feb 22 16:19:48 2023 -0600
Committer:     David Teigland <[email protected]>
CommitterDate: Wed Feb 22 16:19:48 2023 -0600

vgimport: invalidate hints

There may be some unconventional methods of sharing disks with vgimport
where hints could cause confusion.  Hints should be disabled when
sharing disks, or pvscan --cache used to regenerate hints as needed,
but invalidating hints from vgimport might help reduce confusion.
---
 tools/vgimport.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/vgimport.c b/tools/vgimport.c
index 84b76bd8d..d94b11314 100644
--- a/tools/vgimport.c
+++ b/tools/vgimport.c
@@ -14,6 +14,7 @@
  */
 
 #include "tools.h"
+#include "lib/label/hints.h"
 
 static int _vgimport_single(struct cmd_context *cmd,
 			    const char *vg_name,
@@ -48,6 +49,13 @@ static int _vgimport_single(struct cmd_context *cmd,
 
 	log_print_unless_silent("Volume group \"%s\" successfully imported", vg->name);
 
+	/*
+	 * This is not necessary for any normal, known cases, but it could be
+	 * associated with some unconventional method of sharing disks.  Hints
+	 * should be disabled when sharing disks, but this might help.
+	 */
+	invalidate_hints(cmd);
+
 	return ECMD_PROCESSED;
 
 bad:

--
lvm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/lvm-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.