Re: [PATCH] Fix header include for out of tree builds

Anton Lundin <[email protected]>
Newsgroups gmane.linux.lvm.devel
Message-ID <[email protected]>
On 17 May, 2023 - Zdenek Kabelac wrote:

> Dne 16. 05. 23 v 18:05 Anton Lundin napsal(a):
> > The relative include didn't match up for out of tree builds. The
> > build tree include directory is in the include paths already.
> > 
> > Signed-off-by: Anton Lundin <[email protected]>
> > ---
> > 
> > Now the following works:
> > $ mkdir lvm2-build
> > $ cd lvm2-build
> > $ ../lvm2/configure
> 
> Hi
> 
> Your bug is actually in this command:
> 
> configure --srcdir=XXXXX
> 
> > $ make
> > 
> 
> Otherwise srcdir is located in your builddir and you would actually get more
> errors in various parts of lvmb building - as we tend to use $(srcdir)
> inside makefiles..

I might be misunderstanding you. Are your comment about the fix or the
example on now to trigger the bug?

Just running configure from another directory will set srcdir
automatically. At least in any kind of modern auto-tools.


//Anton

--
lvm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/lvm-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.