[PATCH 1/3] dmsetup: return non-zero on stdio I/O error

Demi Marie Obenour <[email protected]>
Newsgroups gmane.linux.lvm.general
Message-ID <Yktp8Jghdz1k5jex@itl-email>
If there is an I/O error on stdout, return a non-zero status so that
udev can avoid trusting the values printed.  Deeper changes to the
log code are out of scope for this patch.
---
 libdm/dm-tools/dmsetup.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libdm/dm-tools/dmsetup.c b/libdm/dm-tools/dmsetup.c
index d01b8f2..0449e40 100644
--- a/libdm/dm-tools/dmsetup.c
+++ b/libdm/dm-tools/dmsetup.c
@@ -7491,5 +7491,7 @@ out:
 	if (_initial_timestamp)
 		dm_timestamp_destroy(_initial_timestamp);
 
+        if (fflush(stdout) || ferror(stdout))
+            return 1;
 	return (_switches[HELP_ARG] || _switches[VERSION_ARG]) ? 0 : ret;
 }
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

_______________________________________________
linux-lvm mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmJLafAACgkQsoi1X/+c
IsFM8Q//aUZPkI+YSVwy9tAi/DZGa4xOFlsop/Vnf8K/7G3AIXjtxSHr14LLd2uX
uluRaXm2Hm2aoHeTHyhUq4JRzhI+t4XlhfLmqpQLFXrSDZSmtIdJ3RO4nbYF5+7B
q2YuWCkrLVvCnTU1YogojWtpOL4y9z3vTzRHZ+4NKByy+DjzkyiDAfK3IxT9cFg+
KmJbmuiCR9si3XMnQAJn6kTDm8ZoHb59sEx/kztlK4XYvlrRVkcX5Tczlk3loOKf
xMeaKEToPYqqnDgF5AkuEWbEoOYnuwQhuwJohoJ6os0jNQRrSriyvaIOM8hOOv9i
g4jqfRrtzkukOOuYQ9/xhmZ8vNnkO+RQW+VYKjTqfu+iUyV09r7vhPyUgwLr1ysw
1lmVwy2G+5Auip2cjrVzBFhvQ7Lz5+GCHfK38Mcz9l0v7n0XHnPHwpRrx8XvnJsK
g3I/Ug/gYVIXd4ydDD5gsmDLb8TpTNdtZFcZ5GcualOVfyvhJTRu9oJHou2JUdbq
Ab5LEu9Gb7TwmdVxlNUiWwRaL5+GF1l7RuvsdYLvYyCaZh5GOPj6TrJ5fqwKZZYa
Ppk3D0UKRglV/LfkcKYCvGUw6Sl1/tFmmTYMT+VFYd92n+7rtyju6NAL5ITouuzm
vcSJQjqNVSUAWBCC9kX3KUYhy1BbXMf89kQGRfcPIclC60bnFzg=
=SBWh
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.