Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83

Dne 16. 11. 23 v 16:10 David Teigland napsal(a):
> On Thu, Nov 16, 2023 at 02:37:13PM +0100, Zdenek Kabelac wrote:
>>> and restore define DEFAULT_USE_DEVICES_FILE 1.
>> There is no problem with configuring DEFAULT_USE_DEVICES_FILE with
>> 'configure --with-default-use-devices-file= 0/1' and thus no need to change
>> anything here.
>>
>> Current upstream has set this default value as 0  (in configure.ac)
> I didn't realize you'd changed the default, please set it back to 1.
> (Even better put back DEFAULT_USE_DEVICES_FILE; configured settings
> are a pain to deal with, and the complexity causes real problems.)

configure is the right way how to set 'default' parameter for compilation.

And since different distribution needs different defaults - it's way better 
then letting every distro maintain some patch sets separately.

Even i.e. building of RHEL8 and RHEL9 have different defaults.

Once the option become supported properly across wide distribution set  - it's 
very easy to flip default in 'configure.ac'  from 0 to 1.

There is no need to change anything else here.

RHEL & Fedora builds are prepared and use proper configure set and build 
proper packages

>> The major problem with turning this  to 1 is the distribution must be
>> 'ready' with such relatively invasive change as it changes also requirements
>> on how the boot image is created  (devicesfile must be copied to ramdisk).
> While a distribution does want to be aware of the change (discussed
> earlier in the thread), what you're saying specifically is not true.
> RHEL, which has this enabled, doesn't even have system.devices in the
> ramdisk.  It simply means that it's not used for activating the root LV.
>

Since lvm2  without 'devicesfiles' will fallback to filters, which by default 
accept 'every' device, this in most cases  will lead to the situation,  that 
if there are no 'specific' needs to filter something out  usually the right LV 
will be activated.

So in most cases even if the 'devicesfile' is not being copied it will appear 
like it's working.

But there will be situation where the systems where lvm2  will be accessing 
devices it should not access - and this is a problem that should be addressed 
(i.e. duplicate devices present in the system).


Zdenek