Re: Re: [cooker-commits] [svn-commit] r769353 - cooker/kcm-grub2/current/SPECS

28.01.2012 02:20, Nicolas Lécureuil пишет:
> On Fri, Jan 27, 2012 at 2:15 PM, dsilakov<[email protected]>  wrote:
>> Author: dsilakov
>> Date: Fri Jan 27 13:15:42 2012
>> New Revision: 769353
>>
>> Added:
>>    cooker/kcm-grub2/current/SPECS/kcm-grub2.spec
>>
>> Log:
>> SILENT: fix release
> fix release ?
>
>
> please use real commit message and please clean this spec file before
> i got an heart attack or  something like this because this seems an
> opensuse spec file imported in mandriva with no modification/cleaning

Indeed.

1. All locales should be managed by find_lang instead of listing every 
file in %files section.

2. make_jobs definition should be removed as we have %make in Mandriva.

3. BuildRoot should be removed as not needed even by RPM4 in 2010.2, not 
to mention RPM5.

4. BuildRequires are just wrong: lib64magick-devel and lib64hd-devel. 64 
bits shouldn't be hardcoded.
Use "rpm -q lib64magick-devel --provides" and choose something better 
from the list :-)

5. $RPM_BUILD_ROOT is something we should avoid. Always use %{buildroot} 
instead.

6. And in any case, we don't need %clean section in RPM5 at all. Keep it 
only when you plan to backport package to 2010.2.

7. You don't have to write "%setup -n %{name}-%{version} -q" because 
it's the same as "%setup -q"

8. For "make -C build DESTDIR=%buildroot install" we have 
"%makeinstall_std" macro

9. All commented junk like " #kde_post_install" should be removed.

Hope this helps :-)