Re: [OM Cooker] i586 uclibc compile problems
Per Øyvind Karlsen <[email protected]> Sun, 23 Jun 2013 04:06:32 +0200
| Newsgroups | gmane.linux.mandrake.cooker.devel |
|---|---|
| Message-ID | <CA+0WU1RxmAdtMwdS=Oog8GDdnJEQML+5e_fQ5DD0m1v60UAZmQ@mail.gmail.com> |
2013/6/23 David Walser <[email protected]> > Certainly I've seen today, while looking at some packages, some commits > from Matt that said cleanups, where some of the changes looked more like > "unnecessary cosmetic changes." That being said, some of the cleanups are > good, but wouldn't be needed if other people wouldn't make them "dirty" in > the first place. Can someone please teach bero that macros that expand to > a value should have braces on them? He's made quite a mess in some places > by neglecting that. Thanks to Matt for cleaning it up where he sees it. > > Indeed. :) More rpmlint checks etc. could prolly' be implemented & introduced to better enforce such further as well, but not very good timing for giving much priority currently.. Prolly' something worthy a broader discussion and focus with timing being better at the beginning of next development cycle. :o) -- Regards, Per Øyvind