Re: [PLF-announce] [RPM] mednafen-0.8.12-1plf2010.0

Zombie Ryushu wrote:
> Name        : mednafen                     Relocations: (not relocatable)
> Version     : 0.8.12                            Vendor: Penguin Liberation Front
> Release     : 1plf2010.0                    Build Date: ven. 14 ao?t 2009 09:09:45 CEST
> Install Date: (not installed)               Build Host: cooker64.home.nanardon.zarb.org
> Group       : Emulators                     Source RPM: (none)
> Size        : 2482122                          License: GPLv2+
> Signature   : (none)
> Packager    : Zombie Ryushu <[email protected]>
> URL         : http://mednafen.sourceforge.net/
> Summary     : Multi-consoles Emulator
> Description :
> Mednafen emulates several consoles : NES, PC Engine, GB, GBA, Lynx.
> 
> This package is in PLF because of Mandriva policy regarding emulators.
> 
> Guillaume Bedot <[email protected]> 0.8.11-1plf2009.1:
> - 0.8.B

No changelog. Please add and reupload.

> --- mednafen.spec	2009/04/19 10:14:04	1.19
> +++ mednafen.spec	2009/08/14 08:06:18	1.20
> @@ -1,14 +1,16 @@
> +%define Werror_cflags %nil

You should rediff patch0 instead of hacking the build like this.

>  Name:			mednafen
> -Version:		0.8.11
> +Version:		0.8.12
>  %define distsuffix	plf
>  Release:		%mkrel 1
>  
>  Summary:	Multi-consoles Emulator
>  License:	GPLv2+
>  URL:		http://mednafen.sourceforge.net/
> +Vendor:         Penguin Liberation Front
> +Packager:       Zombie Ryushu <[email protected]>

Wrong as per Mandriva policy. Remove Vendor and Packager.

>  Group:		Emulators
> -Source0:	http://downloads.sourceforge.net/%{name}/%{name}-0.8.B.tar.bz2
> -Patch0:		mednafen-0.8.B-string-literal.patch
> +Source0:	http://downloads.sourceforge.net/%{name}/%{name}-0.8.C.tar.bz2
>  BuildRequires:	libcdio-devel
>  BuildRequires:	libvorbis-devel
>  BuildRequires:	SDL_net-devel
> @@ -32,7 +34,7 @@
>  
>  %prep
>  %setup -q -n %{name}
> -%patch0 -p1
> +# %patch0 -p1

%patch lines should be removed when the patch is removed. However, in
this case the patch should not be removed (see above).

-- 
Anssi Hannula