Re: Mondoarchive appears to ignore requested tape blocksize

Oh my good grief - mr_popup_and_get_string can never have worked.   

The documentation for newtEntry says:

The resultPtr must be the address of a char *. Until the entry box is
destroyed by newtFormDestroy(), that char * will point to the current value
of the entry box.

The onus is on mr_popup_and_get_string to  malloc an area to hold the
returned string and to copy the data to that malloced area.

Let me see if I can work up a fix.

Dave
-----Original Message-----
From: David C. Partridge [mailto:[email protected]] 
Sent: 14 December 2016 13:36
To: 'Mondo mailing list'
Subject: Re: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Yuk!

Running a (slightly modfied) version of that code:

	
mr_asprintf(sz_size,"%ld",bkpinfo->internal_tape_block_size);
		tmp = mr_popup_and_get_string("Tape block size?", "What is
the block size of your tape streamer?", sz_size);
		if (tmp == NULL) {
			log_to_screen("User has chosen not to backup the
PC");
			finish(1);
		}
		bkpinfo->internal_tape_block_size = atol(tmp);
		mr_free(sz_size); sz_size=NULL; mr_free(tmp); tmp=NULL;
		
under gdb, shows that the compiler has chosen to optimise out the setting of
bkpinfo->internal_tape_block_size . 

It also appears to have optimised out the return value from
mr_popup_and_get_string so the char* value returned bears no relation to the
value that variable entry_value had at line 775 of newt-specfic.c.

Arrgghh!

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

Dave 

-----Original Message-----
From: David C. Partridge [mailto:[email protected]]
Sent: 12 December 2016 19:16
To: 'Mondo mailing list'
Subject: [Mondo-devel] Mondoarchive appears to ignore requested tape
blocksize

Even with the corrected source I just submitted, mondoarchive appears to be
writing buffers of size 32768 (in the case in point I request a tape buffer
of 65536).

amonra@Charon:~$ ps -ef | grep [m]ondo
root      4011 20411  0 19:07 pts/2    00:00:00 sh -c gzip -c1 >
/tmp/mondo.tmp.RkpOWo/acl_list.200.gz
root      9440 20411  0 18:44 pts/2    00:00:00 sh -c buffer -m 32m -p75 -B
-s32768 -o /dev/st0l 2>> /var/log/mondoarchive.log   <--------------- This
line
root     20411 20427  9 18:30 pts/2    00:03:23 ./mondoarchive

Dave




----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mondo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mondo-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot