Re: [PATCH v4 15/17] x86/traps: Fixup general protection faults caused by UMIP
"H. Peter Anvin" <[email protected]>
| Newsgroups | gmane.linux.msdos.general,gmane.linux.kernel,gmane.comp.emulators.wine.devel |
|---|---|
| Message-ID | <[email protected]> |
Luck <[email protected]> From: [email protected] Message-ID: <[email protected]> On February 24, 2017 11:36:19 AM PST, Ricardo Neri <[email protected]> wrote: >On Fri, 2017-02-24 at 11:11 -0800, Andy Lutomirski wrote: >> > In a previous version Andy Lutomirsky suggested that >> > if (user_mode(regs) && (fixup_umip_exception(regs) == 0)) >> > >> > was easier to read :). Although at the time fixup_umip_exception >> > returned a numeric value. Now it only returns true/false for >> > successful/failed emulation. If with true/false not comparing to >> true >> > makes it easier to read, I will make the change. >> >> I think == true is silly :) > >Then I'll make the change. > >Thanks and BR, >Ricardo It's worse than silly, it is potentially toxic. true is a macro which it's defined as 1. Thus foo == true ... doesn't actually mean what people *think* it does, which is roughly the same thing as !!foo However, if foo is not a boolean, this is *very* different; consider if foo is 2. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-msdos" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html