Re: [v6 PATCH 10/21] x86/insn-eval: Do not use R/EBP as base if mod in ModRM is zero
Borislav Petkov <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.msdos.general,gmane.comp.emulators.wine.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 26, 2017 at 06:29:59PM -0700, Ricardo Neri wrote:
> > if (X86_MODRM_MOD(insn->modrm.value) == 0 &&
> > X86_MODRM_RM(insn->modrm.value) == 5)
> >
> > looks more understandable to me.
>
> Should I go with !(X86_MODRM_MOD(insn->modrm.value)) as you suggested in
> other patches?
Ah, yes pls.
Thanks.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--