Re: `among' match

On Tuesday 02 September 2003 23:18, Grzegorz Borowiak wrote:
Hi Grzegorz,

Sorry for acting like I'm ignoring your post, it's just that I've only had a 
brief look at the code, been having some bug reports lately. I should atleast 
give a sign of life when someone sends such cool code. I really like the 
idea.

> I mean, please just add:

That's no problem.

> I hope you'll enjoy the new match.

Some thoughts:
Perhaps it's better to make 2 matches out of it, one for source, one for 
destination. That will save space if you only want source stuff.
What would also be very nice, I think, is the following extension of your 
module: have MAC address - IP address correspondences. So one could have one 
anti-spoofing rule with lots of MAC-IP correspondences.
Also, the negation ('!') should be added, as in "not in this list of MAC 
addresses".
I haven't had a look at the hash implementation, but I think that if feasable 
the number of MAC addresses should be configurable, not hard-coded to 256.

I'll put your code in the CVS. If you plan on doing more coding for ebtables, 
I could give you write access to the CVS.

cheers,
Bart



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf