Re: `among' match

On Wednesday 03 September 2003 19:05, Grzegorz Borowiak wrote:
> > It should be possible to have both matches in one module. ebt_nat
> > userspace is like that. Kernel space should be possible too, the only
> > problem is the name of the matches, since currently ebtables tries to
> > insmod ebt_matchname, which would fail if the match names are different
> > from the kernel file containing both. But this is a userspace problem
> > that can be fixed.
>
> Still I'm not convinced if benefits are worth making such tricks.

Yes, well if the nr of addresses is dynamic, we sure don't need it since 0 
addresses should be allowed too. The only reason I suggested it in the first 
place was preventing 256 empty MAC entries.

> For the folks who need it, maybe I should make a
> CONFIG_BRIDGE_EBT_AMONG_SRCONLY bool config option?

No, that's not worth it.

> So:
>
> allocate new memory
> change the pointer pointed to by that double pointer
> copy everything from old ebt_entry_match to the new one, byte-to-byte
> change the match_size field
> free the memory at the old pointer
>
> Did I get the idea?
>
> If so - OK.

Yup, that's the idea.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf