Re: Patch: ebt_limit update for 2.6

On Friday 24 October 2003 00:56, Tom Marshall wrote:
> On Sat, Oct 18, 2003 at 09:58:31PM +0200, Bart De Schuymer wrote:
> > On Saturday 18 October 2003 15:52, Tom Marshall wrote:
> > > This is the same for ebt_limit.  *WARNING* I have not yet compiled or
> > > tested this, it's an untested merge (my bridge machine is not
> > > accessible from my current location).
> >
> > Please test this patch first before I send it to Dave.
>
> Well, that was instructive.

Well, it's your module. Anyway, I'll test it myself when I get have the time 
then.

> I wrote and tested the original ebt_limit code the on 2.4.21 kernel, and
> I've not used 2.6.0-test for my bridge (being that bridges should probably
> be pretty stable and all...) Turns out that the size of my ebt_entry has
> changed from 28 to 24 because the "master" member disappeared.  I assume
> you did this, correct?

The master member is necessary in iptables because iptables copies the 
complete table for every cpu. Since ebtables only copies the counters for 
each cpu, the master member was not necessary. So yes, I deleted that.

> I also noticed that the userspace patch I sent didn't include
> extensions/ebt_limit.h.  Looks like it should be included to make the
> userspace util compile properly.

The .h file should be the same for kernel and userspace.

cheers,
Bart



-------------------------------------------------------
This SF.net email is sponsored by: The SF.net Donation Program.
Do you like what SourceForge.net is doing for the Open
Source Community?  Make a contribution, and help us add new
features and functionality. Click here: http://sourceforge.net/donate/