Re: Headroom for bridging and wireless

On Sunday 07 December 2003 00:22, Tom Marshall wrote:
> I tried setting br->dev->hard_header_len to the max of the ports (see
> attached patch).  Then I hardcoded hard_header_len to ETH_HLEN+4 for the
> wireless driver.  I verified the kernel messages -- the bridge sets hh_len
> to 18 when I add the wireless device to the bridge and back to 14 when I
> remove it.  Unfortunately, it doesn't seem to be working.  Both bridged
> traffic and traffic from the bridge itself still has 0 headroom in the
> wireless tx function.  :-(

Your patch to br_if.c does seem to use an uninitialized p pointer.
Apart from that, I've just changed the hard_header_len for my bridge box and 
the headroom did increase as it should, for packets originating from the 
bridge and going through br0.
As I said in my previous reply, purely bridged packets will need the 
skb_realloc_headroom function.

cheers,
Bart



-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click