Next problems with ip_conntrack and vlan on 2.6.x

Adam Osuchowski <adwol-QJnc/[email protected]>
Newsgroups gmane.linux.network.bridge.ebtables.devel
Organization Computer Centre of The Silesian University of Technology
Message-ID <[email protected]>
We have sent you a kernel patch over two months ago. It was ment to fix
some problems with IP conntrack and VLANs. Unfortunately, some of your
developers has broken it during the process of rewriting it for kernel
2.6.x.  There is a problem with parentheses. This how it has been
applied (net/ipv4/ip_output.c):

ll_rs = LL_RESERVED_SPACE(rt->u.dst.dev + nf_bridge_pad(skb))

This expands to:

ll_rs = ((rt->u.dst.dev + nf_bridge_pad(skb))->hard_header_len & ~(HH_DATA_MOD - 1)) + HH_DATA_MOD

But, this is how it should look like (after macrodefinition expanding):

ll_rs = ((rt->u.dst.dev->hard_header_len + nf_bridge_pad(skb)) & ~(HH_DATA_MOD - 1)) + HH_DATA_MOD

Regards,
Adam Osuchowski
Tomasz Dubinski

-- 
##  Adam Osuchowski   adwol-QJnc/[email protected], [email protected]
##  Silesian University of Technology, Computer Centre   Gliwice, Poland


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.