Re: Patch for PPPoE IP filtering

Op ma, 07-03-2005 te 23:18 +0100, schreef TESTASECCA Thomas:
> Hi guys, 
> 
>  
> 
> I wrote a patch to add PPPoE support to ebtables IP filtering rules.
> 
> It work with linux 2.6.10 & ebtables 2.06 all details on this page :
> 
> http://ttestasecca.free.fr/ebtables/patch.htm

Hi, thanks for the patch. I have 2 comments that need to be resolved
before I can commit this:

1. destination/source port filtering on PPPoE won't work. A scheme with
skb_pull at the beginning and skb_push at the end of the ebt_filter_ip()
function seems more appropriate.
2. It's better to implement this without using the new mask
EBT_IP_O_PPP. Similar code can be added for IP over vlan or 802.2 and we
don't want a new flag for every such case. Checking the Ethernet
protocol is sufficient.

cheers,
Bart




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click