Re: [PATCH] selective IP NATing on a bridge (like NETMAP)

Op za, 24-12-2005 te 11:10 +0000, schreef Bart De Schuymer:
> Op ma, 19-12-2005 te 04:55 +0100, schreef Carl-Daniel Hailfinger:
> > Please find two patches attached (to avoid whitespace mangling):
> > - lindent of the files I worked on
> > - functional changes only.
> > Patches are against 2.6.15-rc5 and are compile tested only.
> > 
> Did you try if this code works? I don't think it will. Unless something
> recently changed, you can't register 2 targets with the same name in
> arptables. Iptables solved this by introducing the versioning
> (revision). Doing this in arptables will imply rewriting some code in
> arp_tables.c, and I don't think it's worth it (as I said before). Unless
> someone finds the time to actually do those changes and test them of
> course. That's why I referred you to that mail (which got outdated
> w.r.t. the way to do it in iptables now). If you really want to be sure
> what approach to take, you should ask David Miller, as he's the kernel
> maintainer of arptables and your patch will have to be approved by him.

I forgot to note that the revision approach will mean rewriting some of
the arptables userspace code too...




-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click