Re: [PATCH] [EBTABLES] add or/and/xor action support to mark target
David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]>
| Newsgroups | gmane.linux.network.bridge.ebtables.devel |
|---|---|
| Message-ID | <[email protected]> |
From: Bart De Schuymer <[email protected]> Date: Thu, 05 Oct 2006 22:07:58 +0200 > The following patch adds or/and/xor functionality for the mark > target, while staying backwards compatible. Bart, please submit your changes through Patrick McHardy since he is the toplevel netfilter maintainer. He had some problems with your patch already, namely: 1) The comparison of info->target with EBT_RETURN is done without masking out the action. 2) The use of negative numbers makes the code needlessly unreadable compared to just using bitmasks. Thanks. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV