Re: [PATCH] bridge-nf: Allow IPTables to filter PPPoE traffic

> Op do, 01-03-2007 te 14:43 -0500, schreef Michael Milner:
>> > Op ma, 05-02-2007 te 16:48 -0500, schreef Michael Milner:
>> >> Hi,
>> >>
>> >> I've put together some code to allow IPTables to filter PPPoE traffic
>> in
>> >> the same way that bridge-nf allows iptables to filter VLAN traffic.
>> >> [snip]
>> >> The patch is against 2.6.15.  Comments appreciated.  It works fine
>> for
>> >> me
>> >> but I wanted some input before submitting it "officially".
>> >
>> > Please update this to 2.6.20. More comments are below.
>> >
>> > Thanks,
>> > Bart
>> >
>>
>> I've made the changes you requested.  This patch is now based on
>> 2.6.20.1.
>>  I added a defined constant into if_pppoe.h.
>
> Hi,
>
> Thanks for the update, it looks good. I don't want to be annoying, but
> still a few remarks:
> - arp encapsulated in pppoe should be implemented too (this is used with
> pppoe, right?), sorry that I didn't mention that in my previous answer
> [snip]
> cheers,
> Bart

Hi,

Please don't hold back comments, no matter how small.  I want to be able
to avoid those problems in future patches!

As far as I know arp is not used with PPP since it is only a point to
point link.  Also, <linux/ppp_defs.h> does not have any definition for arp
as a ppp payload (like it does for IP and IPv6).

I will make the changes you requested regarding the return statements and
resubmit.

Thanks!

Mike


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV