[PATCH] don't answer gratuitous arp
Bart De Schuymer <[email protected]>
| Newsgroups | gmane.linux.network.bridge.ebtables.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Patrick, The ebtables arpreply target should not answer gratuitous arp's as this has no use and can give rise to problems when client machines send gratuitous arp requests to check for ip conflicts, as reported by Ivan Vladimirov. The attached patch resolves this. cheers, Bart Signed-off-by: Bart De Schuymer <[email protected]> ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Ebtables-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ebtables-devel
arpreply_gratuitous_arp.diff
(text/x-patch, 486 B)
--- linux-2.6.20.1/net/bridge/netfilter/ebt_arpreply.c.old 2007-03-22 21:16:04.000000000 +0100 +++ linux-2.6.20.1/net/bridge/netfilter/ebt_arpreply.c 2007-03-22 21:31:30.000000000 +0100 @@ -50,6 +50,10 @@ static int ebt_target_reply(struct sk_bu if (diptr == NULL) return EBT_DROP; + /* don't answer gratuitous arp */ + if (*diptr == *siptr) + return EBT_CONTINUE; + arp_send(ARPOP_REPLY, ETH_P_ARP, *siptr, (struct net_device *)in, *diptr, shp, info->mac, shp);